fix: make top nav bar right elements within a nav - #63239
fix: make top nav bar right elements within a nav#63239kristian-zendato wants to merge 1 commit into
Conversation
| <div id="contactsmenu"></div> | ||
| <div id="user-menu"></div> | ||
| </div> | ||
| <nav class="header-end" aria-label="<?php p($l->t('User menu')); ?>"> |
There was a problem hiding this comment.
Thats not the user menu, the user menu is the one on the very end.
This navigation should have a different label
Also the content within must have proper roles.
ulneedsrole = menubarlineedsrole = none- button within need
role = menuitem-> this needs to be fixed in NcHeaderButton
There was a problem hiding this comment.
@susnux The user menu is already in nav wrapper.
As far as I checked the comment here(https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1591#issuecomment-5281587123), we need to move the whole top navbar within a nav wrapper which is in div now.
There was a problem hiding this comment.
That's the issue though: wrapping it means nav inside nav. Fine to have the outer one, but then AccountMenu shouldn't set is-nav. And "User menu" is the wrong label for the whole bar either way.
|
|
||
| @media only screen and (max-width: 480px) { | ||
| #header .header-end > div > .menu { | ||
| #header .header-end .menu { |
There was a problem hiding this comment.
Dropping to a descendant selector means any nested .menu in the header matches now, not just the toggle's own. Can you do the same two-selector thing as below?
| inset-inline: 0; | ||
| } | ||
| // Hide all other entries, especially the user menu as it might leak pixels | ||
| :global(.header-end:has(.local-unified-search--open) > :not(.unified-search-menu)) { |
There was a problem hiding this comment.
Can you drop this? The local search bar is Deck-only and Deck already replaced it with its own filter input, so it's getting removed from the header anyway. No point patching selectors on it.
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
384a1bd to
4551f67
Compare
3 participants
Summary
navelement.Checklist
3. to review, feature component)stable32)AI (if applicable)